| 15:21 |
jfw |
billymg: good catch, guess I shoulda studied the original addition when doing the snipping. Not sure why it wouldn't press, pretty sure I tested too but will have a look. You did put my key in .wot? |
| 15:29 |
jfw |
billymg: starting from a fresh dir and importing the patches/seals from the set on my blog, I got "flow" to work, but at first I missed adding diana_coman's key to .wot which was necessary for mp-wp_comments_filtering.vpatch. |
| 15:30 |
diana_coman |
billymg: what error did it give/how did it fail? |
| 15:31 |
jfw |
(v.pl unhelpfully denied that the descendent patch file even existed when asking it for antecedents in that state; the manifest change revealed it) |
| |
~ 5 hours 2 minutes ~ |
| 20:34 |
billymg |
jfw: yes, i imported your key |
| 20:34 |
billymg |
diana_coman: it's a "not found in flow" error |
| 20:35 |
billymg |
i am able to press diana_coman's mp-wp_comments_filtering patch |
| 20:40 |
billymg |
jfw: ah, damn. that's what i missed. i imported your key but didn't place in .wot -- one sec... |
| 20:42 |
billymg |
ok, yeah, presses fine. user error |
| |
~ 42 minutes ~ |
| 21:24 |
jfw |
billymg: cool. Not sure I like the silent failure behavior there, but I could see an argument for it: vtron's job is to pick the good from a sea of bad; that bad patches exist isn't interesting |
| 21:25 |
jfw |
seems there should at least be a verbose or debug option though. |